Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000033OLSRdPluginpublic2012-07-21 23:572012-07-26 07:53
Reportersumpfralle 
Assigned ToHenning 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusresolvedResolutionfixed 
Platformi386OSDebianOS Versionwheezy
Product Version0.6.0 
Target VersionFixed in Version 
Summary0000033: nameservice plugin: configured 'timeout' value is ignored
DescriptionI tried to configure a short timeout value (5 seconds) for host definitions.
But the host definition nevertheless remained active in other olsr hosts for 30 minutes.

Deeper inspection revealed that the "my_timeout" value remained _almost_ unchanged during "set_nameservice_float".
Steps To ReproduceAdd the following debug statement to the beginning and the end of the "set_nameservice_float":

  OLSR_PRINTF(0, "my_timeout: %f\n", my_timeout);

(assuming a "timeout" parameter is set)


The debug output will now show that the "my_timeout" value does not change to the configured value.
Additional InformationThe problem can be fixed by replacing "double timeout" variable definition with "float timeout".
(see line 80 of lib/nameservice/src/nameservice.c)
TagsNo tags attached.
Attached Filespatch file icon olsrd_nameservice_timeout.patch [^] (597 bytes) 2012-07-24 11:21 [Show Content]

- Relationships

-  Notes
(0000051)
Henning (administrator)
2012-07-24 08:48

If you have a patch that solve the problem, just post it on the olsr-dev list. I don't know how many networks are using the Nameservice plugin, but it gives the people a chance to react to the patch.

And by putting it on the list, you get the credit for finding a long term bug in Olsrd. :)
(0000052)
sumpfralle (reporter)
2012-07-24 11:23

ok - now I attached the patch (olsrd_nameservice_timeout.patch).
Please don't be surprised: "replace double with float in line ..." was a complete verbal patch :)

cheers,
Lars
(0000053)
Henning (administrator)
2012-07-26 07:53

Fixed with commit 6eec0ded0e7479d6a9f1366290ebf5a454502275

- Issue History
Date Modified Username Field Change
2012-07-21 23:57 sumpfralle New Issue
2012-07-24 08:48 Henning Note Added: 0000051
2012-07-24 11:21 sumpfralle File Added: olsrd_nameservice_timeout.patch
2012-07-24 11:23 sumpfralle Note Added: 0000052
2012-07-26 07:53 Henning Note Added: 0000053
2012-07-26 07:53 Henning Status new => resolved
2012-07-26 07:53 Henning Resolution open => fixed
2012-07-26 07:53 Henning Assigned To => Henning


Copyright © 2000 - 2010 MantisBT Group
Powered by Mantis Bugtracker